[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 23 May 2020 03:16:25 +0000

Yasuhito FUTATSUKI wrote on Sat, 23 May 2020 11:08 +0900:
> I think it can be fixed by overriding _global_py_pool to $input in "in"
> typemap, when $1 is updated. It assumes that there are no APIs that
> uses two or more result_pool like apr_pool_t * argument for allocationg
> return value.

What about svn_repos_node_editor()? It has two pools, and if I'm
reading the docstring correctly, "pool" will be used both for temporary
allocations and for allocating *editor and *edit_baton, while
"node_pool" will be used to allocate the tree that function constructs.

That function is from 1.0 [according to its docstring], so it precedes
the result_pool/scratch_pool convention by several years.



P.S. Found that with «grep -h -Eo 'apr_pool_t[ *]*[A-Za-z0-9_]*'
subversion/include/*.h | sort | uniq -c».
Received on 2020-05-23 05:16:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.