Re: [PATCH] Update swig INSTALL document for Python 2 bindings

Yasuhito FUTATSUKI wrote on Wed, 20 May 2020 10:18 +0900:
> [[[
> * INSTALL (I.C.13): Add Note that non-release mode is requires to build
> SWIG Python 2 binding.
>

s/13/12/

s/^ SWIG/ SWIG/. Continuation line should be indented at least two
spaces. Most of us indent continuation lines three or four spaces, so
they are indented more deeply than the first letter of the filename.

s/is requires/is required/

s/binding/bindings/

s/to build/for building/. (This is subtler than the others. With "for
building", the sentence would mean what you intend it to mean. With "to
build", the sentence would be grammatical but would have a different
meaning: "is required to" would, in that case, be synonymous with "is
compelled to".)

> +++ INSTALL (working copy)
> @@ -506,7 +506,13 @@
> +++ subversion/bindings/swig/INSTALL (working copy)
> @@ -143,6 +143,7 @@

LGTM. +1 to commit.

Don't forget to nominate this for backport in STATUS if you'd like this
to be backported to 1.14.1. If you have questions, just ask.

Cheers,

Daniel
Received on 2020-05-20 03:54:35 CEST