On 15.05.2020 20:42, Daniel Shahaf wrote:
> Branko Čibej wrote on Fri, 15 May 2020 18:14 +00:00:
>> On 15.05.2020 19:19, Daniel Shahaf wrote:
>>> I just noticed that when I ran «make check» on trunk, it was run using
>>> python 2.7. I hadn't pass any Python-related flags to autogen.sh/configure.
>>>
>>> I presume py2.7 was used because build/find_python.sh used whatever the
>>> "python" executable in my $PATH is.
>>>
>>> Looking at find_python.sh, that's exactly what it does. Shouldn't we
>>> change it to use Python 3 in preference to Python 2, given that we've
>>> documented py2 as no longer supported?
>>
>> Did we actually document that? My impression was that we want to support
>> both.
>>
> The documentation <https://subversion.apache.org/docs/release-notes/1.14#python2>
> reads:
>
> """This means that although Subversion 1.14.0 still technically works
> with Python 2.7, any later 1.14.x point release may drop this
> support if it becomes too difficult to maintain."""
>
I remember now.
>> It would make sense to prefer Python3 over Python2 by default if both
>> are available, but I wouldn't go further than that. The order of
>> executable names should be [python3, python, python2], IIUC the naming
>> conventions.
> Sounds good to me.
>
> If we make this change, should we roll an rc3 for it?
It's a pure build script change, but it's always nice to be able to
essentially rename the RC to the release (except for svn_version.h
changes). I don't think we have to restart the soak, though.
> Otherwise, if we
> in fact pull py2.7 support at some point (as the release notes allow us
> to), we'd find ourselves having to bump a dependency's major version in
> a patch release.
True.
-- Brane
Received on 2020-05-15 22:02:56 CEST