[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Update swig INSTALL document for Python 2 bindings

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 14 May 2020 13:27:40 +0000

Yasuhito FUTATSUKI wrote on Thu, 14 May 2020 19:51 +0900:
> Hi,
>
> I overlooked that 'make clean-swig-py' doesn't remove SWIG generated
> source files if build-output.mk is generated for release mode. It is
> need to clean them to rebuild source files for Python 2 bindings.
>
> So I want to update subversion/bindings/swig/INSTALL so that users don't
> fall into this pitfall. Could anyone please make this better?
>
> [[[
> * subversion/bindings/swig/INSTALL
> (Step 2: Build and Install Subversion.): Add description for optional
> process needed to build Python 2 bindings.
>
> Index: subversion/bindings/swig/INSTALL
> ===================================================================
> --- subversion/bindings/swig/INSTALL (revision 1877407)
> +++ subversion/bindings/swig/INSTALL (working copy)
> @@ -141,6 +141,10 @@
>
> See Subversion's own INSTALL file for details.
>
> + If you are using Subversion distribution tarball and want to build
> + Python bindings for Python 2, you should run 'sh autogen.sh' before run
> + ./configure script to rebuild build environment as non-release mode.

I suggest to add this information to trunk/INSTALL, item (12), instead.

A few tweaks to the text:

  + If you are using a Subversion distribution tarball and want to build
  + the Python bindings for Python 2, you should run 'sh autogen.sh' before running
  + the ./configure script, to rebuild the build environment in non-release mode.

Personally, I prefer to put descriptions before instructions (i.e.,
"you should rebuild the build environment ... by running 'sh
autogen.sh' ..."), but this is by and large a question of style.

> Make sure that Subversion's ./configure script sees your installed SWIG!
> It tries to detect SWIG near the very end of its output.

Preëxisting text, I know, but still: how about changing this to
recommend, say, «grep '^SWIG' config.log», or some other appropriate
command?

Cheers,

Daniel

P.S. Speaking of Python 2, section E.1 of trunk/INSTALL says the Windows
build requires Python 2.7 or greater. Shouldn't that be updated to
require Python 3 (in 1.14 too, as the release notes already document
that)?
Received on 2020-05-14 15:27:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.