Re: [PATCH] Fix differences of SWIG_PY_OPTS between Unix and Windows

On 2020/05/03 8:28, Jun Omae wrote:
> Hi,
>
> Building Subversion trunk with SWIG 4 on Windows, the following errors occur:
>
>
> C:\usr\apps\python38\include\pytime.h(123,67): warning C4115: 'timeval': named type definition in parentheses [C:\usr\src\subversion\trunk\build\win32\vcnet-vcproj\python_core.vcxproj]
> C:\usr\src\subversion\trunk\subversion\bindings\swig\python\core.c(3636,39): warning C4152: nonstandard extension, function/data pointer conversion in expression [C:\usr\src\subversion\trunk\build\win32\vcnet-vcproj\python_core.vcxproj]
> C:\usr\src\subversion\trunk\subversion\bindings\swig\python\core.c(3726,9): error C2065: 'svn_argnum_swig_obj': undeclared identifier [C:\usr\src\subversion\trunk\build\win32\vcnet-vcproj\python_core.vcxproj]
> C:\usr\src\subversion\trunk\subversion\bindings\swig\python\core.c(3726,9): error C2109: subscript requires array or pointer type [C:\usr\src\subversion\trunk\build\win32\vcnet-vcproj\python_core.vcxproj]
> C:\usr\src\subversion\trunk\subversion\bindings\swig\python\core.c(3726,9): error C2198: 'SWIG_Python_ArgFail': too few arguments for call [C:\usr\src\subversion\trunk\build\win32\vcnet-vcproj\python_core.vcxproj]
> ....
> C:\usr\src\subversion\trunk\subversion\bindings\swig\python\core.c(4832,9): error C2065: 'svn_argnum_swig_obj': undeclared identifier [C:\usr\src\subversion\trunk\build\win32\vcnet-vcproj\python_core.vcxproj]
> C:\usr\src\subversion\trunk\subversion\bindings\swig\python\core.c(4832,9): error C2109: subscript requires array or pointer type [C:\usr\src\subversion\trunk\build\win32\vcnet-vcproj\python_core.vcxproj]
> C:\usr\src\subversion\trunk\subversion\bindings\swig\python\core.c(4832,9): fatal error C1003: error count exceeds 100; stopping compilation [C:\usr\src\subversion\trunk\build\win32\vcnet-vcproj\python_core.vcxproj]
>   The command exited with code 2.
> Done executing task "CL" -- FAILED.
> Done building target "ClCompile" in project "python_core.vcxproj" -- FAILED.
> Done Building Project "C:\usr\src\subversion\trunk\build\win32\vcnet-vcproj\python_core.vcxproj" (default targets) -- FAILED.
>
> Done executing task "MSBuild" -- FAILED.
> Done building target "ResolveProjectReferences" in project "python_client.vcxproj" -- FAILED.
> Done Building Project "C:\usr\src\subversion\trunk\build\win32\vcnet-vcproj\python_client.vcxproj" (default targets) -- FAILED.
>
> ...
>
>     87 Warning(s)
>     102 Error(s)
>
> Time Elapsed 00:01:26.67
>
>
> Investigating the issue, I noticed generated SWIG_PY_OPTS differs between Unix and Windows.
>
>     <SWIG_PY_OPTS>-python -py3</SWIG_PY_OPTS>
>
> should be "-python -py3 -nofastunpack" when SWIG 4 is used.
>
> After attached patch, no differences of SWIG_PY_OPTS between Unix and Windows.
 
I'm sorry for delay. Thank you for your contribution. commited in 1877338.

Cheers,

-- 
Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>/<futatuki_at_yf.bsdclub.org>