[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "gen-make.py --debug" with Python 3 fails with TypeError

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 23 Apr 2020 14:53:15 +0000

Johan Corveleyn wrote on Thu, 23 Apr 2020 13:30 +0200:
> On Thu, Apr 23, 2020 at 12:17 AM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp> wrote:
> > [[[
> > Index: gen-make.py
> > ===================================================================
> > --- gen-make.py (revision 1872433)
> > +++ gen-make.py (working copy)
> > @@ -70,7 +70,7 @@
> >
> > if ('--debug', '') in other_options:
> > for dep_type, target_dict in generator.graph.deps.items():
> > - sorted_targets = list(target_dict.keys()); sorted_targets.sort()
> > + sorted_targets = sorted(target_dict.keys(), key=str)
> > for target in sorted_targets:
> > print(dep_type + ": " + _objinfo(target))
> > for source in target_dict[target]:
> > ]]]
>
> Yes, that works :-), both with Py 3.8 and with Py 2.7.
> +1 to commit and propose for backport to 1.14.x.

My +1 to backport as well.
Received on 2020-04-23 16:53:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.