On 2020/04/23 5:53, Johan Corveleyn wrote:
> On Tue, Apr 21, 2020 at 5:14 PM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
>> On 2020/04/21 4:03, Johan Corveleyn wrote:
>>> On Mon, Apr 20, 2020 at 2:16 PM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
>>>> So I wrote a patch for testing (not for commit. it is need to brush up
>>>> even if it can work).
>>>> At least it should work (no regression) on Python 2.7, Python 3 with
>>>> and without PYTHONLEGACYWINDOWSSTDIO on Windows.
>>>> (I confirmed on Python 2.7 and Python 3.7 on FreeBSD).
>>>> Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
>>> Perfect! Works well on Windows, with Py 2.7, 3.7 and 3.8.2, with or
>>> the envvar defined.
>> Thank you!
>> Then I update the patch to prepare to commit. However I don't have
>> confidence function name, variable names, and comment, etc.
>> Could anyone please refine it?
>> Yasuhito FUTATSUKI <futatuki_at_yf.bsdclub.org>/<futatuki_at_poem.co.jp>
> Hi Yasuhito,
> Whoops, I'm not sure anymore if your console fix is entirely correct (or
> perhaps it's missing some extra changes in other parts of the testsuite).
> I was experimenting with your latest patches (for
> merge_conflict_markers_matching_eol), which failed under Python 3.7.7 (I
> only applied your first patch of the latest post, not the second, just to
> see what would happen). Anyway, the point is that, with a failing test,
> there's something going wrong with the output.
> Where's that "I" output on the console coming from? Log statements should
> have been redirected to logfiles.
It seems my second patch for Windows console I/O still not enough.
Perhaps those extra output to console came from internal buffer in some layer,
which didn't flushed via flush() method just before redirection, or there
exist other reference of old sys.stdout, sys.stderr I'm overlooking.
Traceback in log file indicates those problem occurs around spawn_process()
> Any idea?
I'll read code again, however I'm not sure I can solve this problem....
Yasuhito FUTATSUKI <futatuki_at_yf.bsdclub.org> / <futatuki_at_poem.co.jp>
Received on 2020-04-23 01:48:34 CEST