Re: Problems running testsuite on Windows with Python 3

On Fri, Apr 17, 2020 at 11:21 PM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp> wrote:
>
> On 2020/04/17 5:53, Johan Corveleyn wrote:
>
> > Running the testsuite with Py 3.8.2 with PYTHONLEGACYWINDOWSSTDIO
> > defined in the environment allows it to complete. It results in 68
> > FAILS (for ra_local x fsfs). See attached fails.log.
>
> I hope a part of the problems may fixed by attached patch, however,
> I can't see why these test was passed in Python 2.7.

Thanks! That fixes two of the tests. These two now pass after applying
your patch (so feel free to commit -- I also checked again with Python
2.7 and still all tests successful):

mergeinfo_tests.py 13: do not record mergeinfo on tree conflict victims
update_tests.py 47: tree conflicts on update UC1, update deleted tree

This is the list of tests that still fail (66):

FAIL: blame_tests.py 18: blame_youngest_to_oldest
FAIL: merge_tests.py 34: conflict markers should match the file's eol style
FAIL: merge_tests.py 35: handle eol-style propchange during merge
FAIL: patch_tests.py 13: patch target with no svn:eol-style
FAIL: patch_tests.py 14: patch target with svn:eol-style
FAIL: patch_tests.py 15: patch target with uncommitted svn:eol-style
FAIL: svnadmin_tests.py 35: detect denormalized names and name collisions
FAIL: svndumpfilter_tests.py 7: svndumpfilter with an empty prefix
FAIL: svnrdump_tests.py 1: dump: standard sbox repos
FAIL: svnrdump_tests.py 2: dump: revision zero
FAIL: svnrdump_tests.py 3: load: revision zero
FAIL: svnrdump_tests.py 4: dump: skaeleton repository
FAIL: svnrdump_tests.py 5: load: skeleton repository
FAIL: svnrdump_tests.py 6: dump: sparse file/dir propchanges
FAIL: svnrdump_tests.py 7: load: sparse file/dir propchanges
FAIL: svnrdump_tests.py 8: dump: copy and modify
FAIL: svnrdump_tests.py 9: load: copy and modify
FAIL: svnrdump_tests.py 10: dump: copy from previous version and modify
FAIL: svnrdump_tests.py 11: load: copy from previous version and modify
FAIL: svnrdump_tests.py 12: dump: modified in place
FAIL: svnrdump_tests.py 13: load: modified in place
FAIL: svnrdump_tests.py 14: dump: tag empty trunk
FAIL: svnrdump_tests.py 15: load: tag empty trunk
FAIL: svnrdump_tests.py 16: dump: tag trunk containing a file
FAIL: svnrdump_tests.py 17: load: tag trunk containing a file
FAIL: svnrdump_tests.py 18: dump: tag trunk containing a file (#2)
FAIL: svnrdump_tests.py 19: load: tag trunk containing a file (#2)
FAIL: svnrdump_tests.py 20: dump: directory property changes
FAIL: svnrdump_tests.py 21: load: directory property changes
FAIL: svnrdump_tests.py 22: dump: copy parent and modify prop
FAIL: svnrdump_tests.py 23: load: copy parent and modify prop
FAIL: svnrdump_tests.py 24: dump: url encoding issues
FAIL: svnrdump_tests.py 25: load: url encoding issues
FAIL: svnrdump_tests.py 26: dump: copy revprops other than svn:*
FAIL: svnrdump_tests.py 27: load: copy revprops other than svn:*
FAIL: svnrdump_tests.py 28: dump: subdirectory
FAIL: svnrdump_tests.py 29: dump: subdirectory with changes on root
FAIL: svnrdump_tests.py 30: dump: copy revs with no svn:author revprops
FAIL: svnrdump_tests.py 31: load: copy revs with no svn:author revprops
FAIL: svnrdump_tests.py 32: dump: move parent & modify child file in same rev
FAIL: svnrdump_tests.py 33: load: move parent & modify child file in same rev
FAIL: svnrdump_tests.py 34: dump: inconsistent line endings in svn:* props
FAIL: svnrdump_tests.py 35: load: inconsistent line endings in svn:* props
FAIL: svnrdump_tests.py 36: dump: non-LF line endings in svn:* props
FAIL: svnrdump_tests.py 37: dump: commit a copy of root
FAIL: svnrdump_tests.py 38: load: commit a copy of root
FAIL: svnrdump_tests.py 39: dump: descending into replaced dir looks in src
FAIL: svnrdump_tests.py 40: load: descending into replaced dir looks in src
FAIL: svnrdump_tests.py 41: dump: add with multiple props
FAIL: svnrdump_tests.py 42: load: multiple prop edits on a file
FAIL: svnrdump_tests.py 43: svnrdump renumbers dropped revs in mergeinfo
FAIL: svnrdump_tests.py 44: don't drop mergeinfo revs in incremental svnrdump
FAIL: svnrdump_tests.py 45: svnrdump load partial incremental dump
FAIL: svnrdump_tests.py 46: dump: using -rX:Y
FAIL: svnrdump_tests.py 47: dump: subdirectory using -rX:Y
FAIL: svnrdump_tests.py 48: dump: deeper subdirectory using -rX:Y
FAIL: svnrdump_tests.py 49: load: prop change in non-deltas dump
FAIL: svnrdump_tests.py 50: dump: mergeinfo that contains r0
FAIL: svnrdump_tests.py 52: load non-deltas copy with props
FAIL: svnrdump_tests.py 53: load non-deltas replace&copy with props
FAIL: svnrdump_tests.py 54: dump replace with copy
FAIL: svnrdump_tests.py 55: load non-deltas with props
FAIL: svnrdump_tests.py 56: load: invalid svn:date revprop in r0
FAIL: svnrdump_tests.py 57: load: invalid svn:date revprop in r1
FAIL: update_tests.py 26: conflict markers should match the file's eol style
FAIL: update_tests.py 27: handle eol-style propchange during update

See fails2.log in attachment.

-- 
Johan