[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1875921 - in /subversion/trunk: subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/client-side/

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Thu, 2 Apr 2020 09:29:33 +0200

On Thu, Apr 2, 2020 at 2:06 AM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>
> Stefan Sperling wrote on Wed, 01 Apr 2020 11:58 +00:00:
> > FWIW, "You are expected to fix it" could also be interpreted as hostile.
> > It's a direct order from you directed at me, telling me what I should do.
>
> You committed a bug so I asked you to fix it, just like when Denis broke
> the build you asked him to fix it.
>
> However, that was the ONLY thing I actually expected you to do. The
> debugging suggestions were posted for whomever happened to have time to
> investigate the bug, not for you personally. I apologize for my part in
> the Swiss cheese of that miscommunication (whatever it was; I don't see it).

Daniel,

As I told you off-list (but perhaps that wasn't such a good idea after
all, to respond off-list): I don't sense any hostility from Stefan
here. Perhaps impatience and frustration that RM'ing 1.14 is taking
him more time and effort than expected, and that "a missing docstring
on a private static function" is holding it back (for a patch that he
tried to get in at the last minute (a noble effort BTW to give a new
contributor a timely result)), but hostility? Nah.

OTOH: "You are expected to ..." does not sound like a question to me,
it really sounds like an order. Also: it's not solely up to Stefan to
fix this (or any) bug, not even if he caused the bug / omission
himself (in this case, by shepherding another's patch). Anyone can
join the effort and fix others' bugs. Otherwise, we could hold any
contributor here forever responsible for any work they did (which
invariable contains bugs). I guess that's what Stefan meant with
"Wouldn't it be enough if you or someone else added docstrings on
trunk
at some convenient point in time in the future" and "I would feel a
lot better if you did work to improve upon existing work and then
showed me "this is how you could have done it, what do you think?"
instead of making suggestion after suggestion and expecting results
from me."

Putting myself in Stefan's shoes, I can certainly understand the
feeling of "a good deed never goes unpunished", which seems to go with
taking on the RM task (or for sticking out your neck for anything,
really).

I'm sorry I'm not doing anything significant these days myself. I'm
happy Stefan is doing the RM work, and trying to get another release
out the door. Just as I'm happy that you (Daniel) and others are
keeping an eye on things, reviewing and bringing up issues, and
helping where they can. Just ... try to be as supportive and
encouraging as you can for each other's efforts, thanks :-).

-- 
Johan
Received on 2020-04-02 09:29:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.