[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1876016 - /subversion/trunk/subversion/bindings/swig/INSTALL

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 2 Apr 2020 00:07:31 +0000

Good morning futatuki@,

futatuki_at_apache.org wrote on Wed, 01 Apr 2020 21:07 -0000:
> Explain SWIG is needed for building Python 2 bindings.
>
> Since Subversion distibution 1.14.0 and later will ship with SWIG Python
> bindings *.c source code for Python 3, clarify *.c source files for Python 2
> and Python 3 are different and incompatible, and describe how to clear
> incompatible intermediate files.
>
> * subversion/bindings/swig/INSTALL
> (STATUS OF THE SWIG BINDINGS):
> Add explanation about supported Python version and distribution tarball.
> (BUILDING SWIG BINDINGS FOR SVN ON UNIX Step 1):
> Add new case that SWIG is needed for Python 2 bindings.
> (BUILDING SWIG BINDINGS FOR SVN ON UNIX Step 2):
> Update Python and perl version in commadline example.
> (BUILDING SWIG BINDINGS FOR SVN ON UNIX Step 3):
> Insert optional step to clear intermediate files previously generated.
> (everywhere) Strip trailing white space in the end of line.

Thanks for this. May I propose a few tweaks? Patch attached, as well
as its wdiff for review purposes. The changes are mainly:

- Use passive voice

- Rearrange information to put the common case first and rarer cases
  nearer the end

Let me know if I missed anything.

Furthermore, since this documentation is for 1.14.0, I assume it should
be backported to branches/1.14.x? If that is the case, feel free to go
ahead and add it to branches/1.14.x/STATUS. (You can automate editing
and committing the STATUS file by running «tools/dist/nominate.pl
r1876016 "hello world"» in a working copy of branches/1.14.x.)

Apologies in advance but I'll not be online much in the next few days,
so I may be slow to respond.

Cheers,

Daniel

Received on 2020-04-02 02:07:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.