[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svnadmin build-repcache command

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 1 Apr 2020 19:14:21 +0200

On Wed, Apr 01, 2020 at 06:40:27PM +0200, Stefan Sperling wrote:
> This seems to fix it.
>
> I don't understand why this is necessary but the regular code path for
> access to node revision data in fsfs also seems to apply this always.
>
> Can an fsfs expert confirm?

Since this fix looks reasonable to me and we're trying to move the release
process forward, I have decided to commit the change and have added it to
the backport nomination as well.

> Index: subversion/libsvn_fs_fs/fs_fs.c
> ===================================================================
> --- subversion/libsvn_fs_fs/fs_fs.c (revision 1875921)
> +++ subversion/libsvn_fs_fs/fs_fs.c (working copy)
> @@ -2393,6 +2393,10 @@ reindex_node(svn_fs_t *fs,
> SVN_ERR(svn_fs_fs__read_noderev(&noderev, rev_file->stream,
> pool, pool));
>
> + /* Make sure EXPANDED_SIZE has the correct value for every rep. */
> + SVN_ERR(svn_fs_fs__fixup_expanded_size(fs, noderev->data_rep, pool));
> + SVN_ERR(svn_fs_fs__fixup_expanded_size(fs, noderev->prop_rep, pool));
> +
> /* First reindex sub-directory to match write_final_rev() behavior. */
> if (noderev->kind == svn_node_dir)
> {
>
>
Received on 2020-04-01 19:14:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.