[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1875921 - in /subversion/trunk: subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/client-side/

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 1 Apr 2020 09:34:39 +0000

Stefan Sperling wrote on Wed, 01 Apr 2020 10:31 +0200:
> On Wed, Apr 01, 2020 at 01:43:28AM +0000, Daniel Shahaf wrote:
> > Daniel Shahaf wrote on Tue, 31 Mar 2020 09:23 +00:00:
> > > Please add a docstring.
> >
> > I've gone ahead and added this to STATUS so it doesn't slip through any
> > cracks. Feel free to remove the -0 vote once it's been addressed (you
> > needn't round-trip through me for this).
>
> Wouldn't it be enough if you or someone else added docstrings on trunk
> at some convenient point in time in the future, and then nominated that
> revision as a regular follow-up change if it's deemed important enough?
>

No, it wouldn't. You committed two new functions without docstring.
That's a bug in your commit. You are expected to fix it.
Received on 2020-04-01 11:34:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.