[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1875921 - in /subversion/trunk: subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/client-side/

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 31 Mar 2020 09:23:29 +0000

stsp_at_apache.org wrote on Tue, 31 Mar 2020 08:53 -0000:
> +++ subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c Tue Mar 31 08:53:55 2020
> @@ -2343,3 +2344,168 @@ svn_fs_fs__info_config_files(apr_array_h
> }
> +
> +static svn_error_t *
> +ensure_representation_sha1(svn_fs_t *fs,
> + representation_t *rep,
> + apr_pool_t *pool)

Please add a docstring.

> +{
> + if (!rep->has_sha1)
> + {
> + svn_stream_t *contents;
> + svn_checksum_t *checksum;
> +
> + SVN_ERR(svn_fs_fs__get_contents(&contents, fs, rep, FALSE, pool));
> + SVN_ERR(svn_stream_contents_checksum(&checksum, contents,
> + svn_checksum_sha1, pool, pool));
> +
> + memcpy(rep->sha1_digest, checksum->digest, APR_SHA1_DIGESTSIZE);
> + rep->has_sha1 = TRUE;
> + }
> +
> + return SVN_NO_ERROR;
> +}
> +
> +static svn_error_t *
> +reindex_node(svn_fs_t *fs,
> + const svn_fs_id_t *id,
> + svn_revnum_t rev,
> + svn_fs_fs__revision_file_t *rev_file,
> + svn_cancel_func_t cancel_func,
> + void *cancel_baton,
> + apr_pool_t *pool)

Please add a docstring.

> +{

Cheers,

Daniel
Received on 2020-03-31 11:23:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.