[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svnadmin build-repcache command

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 25 Mar 2020 21:56:23 +0000

Nathan Hartman wrote on Wed, 25 Mar 2020 17:30 -0400:
> On Wed, Mar 25, 2020 at 9:17 AM Stefan Sperling <stsp_at_elego.de> wrote:
> > I rolled 1.14.0-rc1 this morning, and I didn't notice that you had
> > posted this updated patch yesterday. Sorry about the bad timing.
> > The 1.14.0-rc1 release does not have your patch. But until .0 has been
> > released we can still decide to add new commands to 'svnadmin' for SVN 1.14.
> >
> > I don't think this is a de-stabilizing change and the feature is small
> > and useful. I would be in favour of adding it to 1.14.0, provided the
> > patch gets committed to trunk and nominated for backport to 1.14.0 soon.
> > And of course all our regression tests need to keep passing.
> >
> > Otherwise this change would have to wait throughout the entire 1.15
> > release cycle, at least according to our release policy guidelines.
> >
> > Would any of our committers be able to shepherd this patch through
> > without a lot of lag? Please let me know.
>
> FYI, I tested 1.14.0-rc1 today, but I'm not rushing to sign (yet)
> because I'm waiting to see if we'll get Denis's patch (or a later
> version of it) into 1.14.
>
> I tested *without* Denis's patch, but I'll test again with it and keep
> the list posted.

What kind of tests do you have in mind? Denis's patch has virtually
zero interaction with existing tests, so a 'make check' run wouldn't
teach us much, IMO: it wouldn't run the new code at all, other than the
newly-added test itself. On the other hand, running the new subcommand
on a repository as it's receiving commits would be interesting.

(Furthermore, if you're so inclined, you could review the 'structure'
file and then help review the code for issues that can be found by
review but not by testing.)

Cheers,

Daniel
Received on 2020-03-25 22:56:33 CET

This is an archived mail posted to the Subversion Dev mailing list.