Re: [PATCH] svnadmin build-repcache command

> Well, maybe. The code _appears_ to take a roundabout approach, but I'm
> not sure that's actually a bug: there might be a difference between
> «INSERT OR IGNORE» on the one hand, and the current behaviour («INSERT
> OR FAIL» plus a C check) on the other.
>
> Is «INSERT OR IGNORE» supported by all SQLite versions we support?
>

Yes, INSERT OR IGNORE supported by all versions. I plan to start a separate
thread about this topic.

> However, 'svnadmin pack' doesn't "silently succeed" when packing is
> disabled; it prints a warning. So the question now is whether a warning
> — i.e., an API notification — should be emitted when rep-sharing is
> supported by the library and the fs format but disabled in fsfs.conf.
> WDYT?
>

I think it makes sense to have such behavior here. I implemented it
with a special error code that svnadmin handles as a warning (because
the approach used by svn_fs_fs__pack() doesn't seem to be technically
applicable here).

> I'm proposing to modify fs_has_rep_sharing() to return True when running
> on FSFS with rep-sharing enabled and to return False on other backends.
> That's separate from your test's decorators.
>

I think that this might be unrelated to this patch, but also I may be
misunderstanding
what exactly you propose. If we modify fs_has_rep_sharing() to return True
for FSFS and to return False for other backends, we will have a problem
with FSX,
which also supports rep-sharing.

I've attached an updated patch.

Regards,
Denis Kovalchuk