Stefan Sperling wrote on Sat, 14 Mar 2020 16:59 +0100:
> On Sat, Mar 14, 2020 at 03:47:44PM +0000, Daniel Shahaf wrote:
> > What is it that I'm supposed to share my assessment of? My involvement
> > in shelving consisted of little more than conducting two commit
> > reviews.
>
> Whether you're OK with that code you've reviewed to be shipped as it is.
> It sounds like you have no concerns and we're good :)
I have reviewed subversion/svn/svn.c:2071-2081 and am happy for those
eleven lines to be shipped as is.
I have also reviewed the test suite support for those lines, and have
raised a concern that has not yet been addressed:
https://mail-archives.apache.org/mod_mbox/subversion-dev/202002.mbox/%3C77bc96f0-6d5a-4f77-8d69-029e77fc4380%40www.fastmail.com%3E
(tl;dr: the shelf2/shelf3 tests don't run by default, but should, but
the implementation is not as simple as setting an environment variable
globally.)
As to the assessing the releasability of the remaining 10k LOC of the
shelving feature, I have not reviewed them so I defer to Julian.
Cheers,
Daniel
(There's also the release notes for shelving, which are being worked on
and in any case don't block branching or rolling.)
Received on 2020-03-14 18:18:59 CET