Re: svn commit: r1874634 [3/3] - in /subversion/branches/decouple-shelving-cli/subversion: include/private/svn_client_shelf2.h libsvn_client/shelf2.c svn/shelf2-cmd.c svn/shelf2-cmd.h svn/svn.c tests/cmdline/shelf2_tests.pyj

Julian Foad wrote on Sat, 29 Feb 2020 08:12 +00:00:
>
> Daniel Shahaf wrote:
>
>
> >
> > This doesn't seem forward-compatible: if in 1.15 we add
> > SVN_EXPERIMENTAL_COMMANDS=foo, using that environment variable setting
> > on 1.14 (assuming the above branch is merged by 1.14) would disable
> > shelving. I'm aware that compatibility is a lesser concern for experimental
> > features, but still, this sort of compatibility seems achievable.
> >
> >
>
>
> I didn't want this commit to change the default, but I think it would
> be reasonable now to change the default to a simple opt-in (each
> feature is enabled iff the var contains its feature-name) for 1.14.
>
> WDYT?

Off the top of my head: that'd be a sensible design, but it's not the
only conceivable design that'd be sensible. For example, designs that
enable some or all experimental subcommands by default would be sensible
too, since those subcommands' names already have "x-" prefixes to warn
of their experimental status.

Cheers,

Daniel
Received on 2020-02-29 14:48:37 CET