Moving from users@:
On Tue, Jan 21, 2020 at 8:31 PM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Nathan Hartman wrote on Tue, 21 Jan 2020 14:26 +00:00:
> > The FSX back end is a work in progress and not ready for production use.
>
> Then shouldn't «svnadmin create --fs-type=fsx» emit a warning to that effect, like --fs-type=bdb does?
It could with a patch like the one below (which is INCOMPLETE because
create_repos() in subversion/tests/cmdline/svntest/main.py needs to be
adjusted to expect this extra output)...
BUT:
According to the OP's stack trace, the exception was an access
violation in svn_fs_print_modules():
Stacktrace:
#1 0x7fff2af55583 in svn_fs_print_modules()
#2 0x7fff2af5627d in svn_fs_create2()
#3 0x7fff0e7c03b6 in svn_repos_create()
#4 0x7ff751112e46 in (unknown function)
#5 0x7ff7511138de in (unknown function)
#6 0x7ff75111699d in (unknown function)
#7 0x7ff7511111e2 in (unknown function)
#8 0x7fff37da7bd4 in BaseThreadInitThunk()
#9 0x7fff3880ced1 in RtlUserThreadStart()
Also I notice that the command was:
C:\ >svnadmin create --fs-type fs_x %SVN_HOME%\repos\newProjectRepos
Note the --fs-type fs_x rather than fsx. That doesn't seem right.
Maybe any garbage passed in the --fs-type parameter will cause an
access violation?
That was with 1.12.0 on Windows and I haven't investigated further.
Maybe failed pool allocations are reported that way on Windows?
INCOMPLETE patch (affects subcommand_create()):
[[[
Index: subversion/svnadmin/svnadmin.c
===================================================================
--- subversion/svnadmin/svnadmin.c (revision 1873037)
+++ subversion/svnadmin/svnadmin.c (working copy)
@@ -865,6 +865,21 @@
"svnadmin: ", SVN_FS_TYPE_BDB, SVN_FS_TYPE_FSFS));
fflush(stderr);
}
+
+ /* FSX should not be used in production yet. Currently, it is
+ * for experimental and development use. Until it is ready, warn
+ * users if they choose FSX. */
+ if (0 == strcmp(opt_state->fs_type, SVN_FS_TYPE_FSX))
+ {
+ SVN_ERR(svn_cmdline_fprintf(
+ stderr, pool,
+ _("%swarning:"
+ " The \"%s\" repository back-end is EXPERIMENTAL,"
+ " consider using \"%s\" instead.\n"),
+ "svnadmin: ", SVN_FS_TYPE_FSX, SVN_FS_TYPE_FSFS));
+ fflush(stderr);
+ }
+
svn_hash_sets(fs_config, SVN_FS_CONFIG_FS_TYPE, opt_state->fs_type);
}
]]]
And this patch won't apply because my stupid MUA will change the tabs to
spaces, but I don't want it to apply because it's incomplete. So this is
a feature, not a problem. :-)
Nathan
Received on 2020-01-22 17:00:36 CET