[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Makefile.svn: a dumb question

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 28 Dec 2019 17:13:27 +0000

Nathan Hartman wrote on Fri, Dec 27, 2019 at 15:39:10 -0500:
> On Fri, Dec 27, 2019 at 12:41 AM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > Nathan Hartman wrote on Thu, Dec 26, 2019 at 17:02:21 -0500:
> > > (If you're wondering about /dev/sdb1, it appears to be a regular disk,
> > > not a ramdrive, because this is a virtual machine and the ramdrive is
> > > a disk image in RAM on the host. This allows it to persist through
> > > reboots of the guest, moved to other guests, etc).
> >
> > But if the guest's kernel sees an ordinary block device, it'll still try to
> > sync(2) it, won't it? I wonder if you'll see any benefit from eatmydata(1).
>
> Yes, it's kind of dumb to sync to a ramdisk. I'll play around with
> eatmydata and see how much of a difference it makes in execution time.
> Maybe I'll use that when I'm in a hurry. The full test suite with all
> RA and backends took nearly 2.5 hours. I didn't know about eatmydata.
> Thanks for mentioning it.

For reference, on my desktop it takes 56s to build and 581s to run a single
svnserveautocheck. It's a non-virtualized maintainer mode build.

> > > I don't know why the test failed before. Could be timing or something
> > > else happening on the computer? As I continue experimenting, we'll see
> > > if it fails again... I'll keep everyone posted.
> >
> > Forgot to say this earlier, but you might try running a threaded svnserve. In
> > plain trunk that's «make svnserveautocheck THREADED=1»; I don't know how to do
> > that in stsp's distro.
>
> I'll give it a try. I have to study how the makefile invokes the
> regression tests.
>
> There is a variable THREADING in the makefile; it defaults to yes and
> activates threading and thread-safety stuff in apr, gettext, ruby, and
> sqlite. It has no effect on the Subversion build or tests.

To be clear, I was referring to the variable THREADED in Subversion's Makefile,
not to anything in stsp's distro. Perhaps this? —

Index: tools/dev/unix-build/Makefile.svn
===================================================================
--- tools/dev/unix-build/Makefile.svn (revision 1871981)
+++ tools/dev/unix-build/Makefile.svn (working copy)
@@ -2165,6 +2165,7 @@
     env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) $(LIB_PTHREAD_HACK) \
         env MAKEFLAGS= make check PARALLEL=$(PARALLEL) CLEANUP=$(CLEANUP) \
           EXCLUSIVE_WC_LOCKS=$(EXCLUSIVE_WC_LOCKS) \
+ THREADED=$(THREADED) \
           SVN_BIN_DIR=$(SVN_PREFIX)/bin \
           MEMCACHED_SERVER=$(MEMCACHED_SERVER) $1 FS_TYPE=$$fs; \
     for log in tests.log fails.log; do \

(If it works for you, feel free to commit it, but note the comment at the top
of the file.)

Cheers,

Daniel
Received on 2019-12-28 18:13:41 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.