Re: Makefile.svn: a dumb question

On Thu, Dec 26, 2019 at 6:00 AM Stefan Sperling <stsp_at_elego.de> wrote:
> On Thu, Dec 26, 2019 at 02:37:03AM +0000, Daniel Shahaf wrote:
> > It would be nice to find a way for you to share your changes without breaking
> > the bot. Could you talk to stsp about this?
>
> Yes I can help here. Please share your patches and I will integrate them.
> I kept serf-old around to be able to build 1.5 but at this point it's fine
> for me to lose the ability to build it.

I'm attaching 3 patches:

* patch-1-serf-only.txt - Only update to Serf 1.4.x.

* patch-2-sasl-only.txt - Only update to Cyrus SASL 2.1.27.

* full-patch.txt - Contains both of the above + remove all Serf-Old
  stuff for svn 1.5.

You can choose to apply changes in several commits by applying them in
that order, or, you can apply just full-patch.txt to get all the
changes.

Thanks for helping with fails.log.* and pointing out to grep the
binding test log files per the svn-bb-openbsd buildbot scripts. That's
very helpful. :-)

One more question: Does anyone know which package(s) to install on
Debian to be able to run the JavaHL tests?

Regarding the svnserve x bdb test failure:

> > Observations from running the regression tests:
> >
> > (1) I get one test failure in [svn x bdb]:
> > FAIL: autoprop_tests.py 7: import: config=no, commandline=none
> >
> > This test passes for all other RA x backend combinations.
>
> With trunk on Linux:
>
> % make svnserveautocheck FS_TYPE=bdb CLEANUP=1 TESTS="subversion/tests/cmdline/autoprop_tests.py"
> ⋮
> SUMMARY: All tests successful
> %
>
> What was the error (in the .log file)?

Here are the contents of fails.log.svn-check-svn-bdb -- could be some
kind of fluke? I just started another full test run. Let's see if it
repeats:

[[[
W: * Dumped revision 0.
subversion/svnadmin/svnadmin.c:1475,
subversion/libsvn_repos/dump.c:2175,
subversion/libsvn_delta/path_driver.c:190,
subversion/libsvn_delta/path_driver.c:328,
subversion/libsvn_repos/replay.c:534,
subversion/libsvn_fs/fs-loader.c:1223,
subversion/libsvn_fs_base/tree.c:1193,
subversion/libsvn_fs_base/tree.c:1165,
subversion/libsvn_fs_base/tree.c:1026,
subversion/libsvn_fs_base/trail.c:218,
subversion/libsvn_fs_base/trail.c:159,
subversion/libsvn_fs_base/bdb/bdb-err.c:85,
subversion/libsvn_fs_base/bdb/bdb-err.c:79: (apr_err=SVN_ERR_FS_BERKELEY_DB)
svnadmin: E160029: Berkeley DB error for filesystem
'svn-test-work/local_tmp/repos/db' while committing Berkeley DB
transaction:
DB_RUNRECOVERY: Fatal error, run database recovery
subversion/libsvn_fs_base/bdb/env.c:230: (apr_err=SVN_ERR_FS_BERKELEY_DB)
svnadmin: E160029: bdb: PANIC: fatal region error detected; run recovery

W: CMD: /home/nate/ramdrive/svndev/prefix/svn-trunk/bin/svnadmin dump
svn-test-work/local_tmp/repos terminated by signal 6
W: CWD: /home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline
W: EXCEPTION: SVNProcessTerminatedBySignal
Traceback (most recent call last):
  File "/home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline/svntest/main.py",
line 1931, in run
    rc = self.pred.run(sandbox)
  File "/home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline/svntest/testcase.py",
line 178, in run
    result = self.func(sandbox)
  File "/home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline/autoprop_tests.py",
line 245, in autoprops_imp_no_none
    autoprops_test(sbox, 'import', 0, 0, '')
  File "/home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline/autoprop_tests.py",
line 101, in autoprops_test
    sbox.build()
  File "/home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline/svntest/sandbox.py",
line 164, in build
    minor_version, tree)
  File "/home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline/svntest/actions.py",
line 1994, in make_repo_and_wc
    guarantee_greek_repository(sbox.repo_dir, minor_version)
  File "/home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline/svntest/actions.py",
line 193, in guarantee_greek_repository
    _guarantee_repos(path, main.pristine_greek_repos_dir, minor_version)
  File "/home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline/svntest/actions.py",
line 178, in _guarantee_repos
    failed = main.copy_repos(repos_dir, path, 1, 1, minor_version)
  File "/home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline/svntest/main.py",
line 1246, in copy_repos
    dump_stdout, dump_stderr, dump_exit_code = wait_on_pipe(dump_kid, True)
  File "/home/nate/ramdrive/svndev/svn-trunk/subversion/tests/cmdline/svntest/main.py",
line 557, in wait_on_pipe
    raise SVNProcessTerminatedBySignal
svntest.main.SVNProcessTerminatedBySignal
FAIL: autoprop_tests.py 7: import: config=no, commandline=none
]]]

Thanks,
Nathan