[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1871827 - /subversion/trunk/subversion/bindings/swig/python/tests/client.py

From: Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
Date: Fri, 20 Dec 2019 22:31:57 +0900

On 2019/12/20 21:11, Stefan Sperling wrote:
> On Fri, Dec 20, 2019 at 08:47:38PM +0900, Yasuhito FUTATSUKI wrote:
>> And then, another problem has been occurred ... in
>> SubversionClientTestCase.test_shelf(). I'll take a look.
>>
>> https://ci.apache.org/builders/svn-bb-openbsd/builds/464/steps/Test%20bindings/logs/testlog-swig-py
>
> This the corresponding backtrace:

Thank you for your quick responce.

> GNU gdb (GDB) 7.12.1
> Copyright (C) 2017 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law. Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "sparc64-unknown-openbsd6.6".
> Type "show configuration" for configuration details.
> For bug reporting instructions, please see:
> <http://www.gnu.org/software/gdb/bugs/>.
> Find the GDB manual and other documentation resources online at:
> <http://www.gnu.org/software/gdb/documentation/>.
> For help, type "help".
> Type "apropos word" to search for commands related to "word"...
> Reading symbols from prefix/python/bin/python3.7...done.
> [New process 320142]
> Core was generated by `python3.7'.
> ---Type <return> to continue, or q <return> to quit---
> Program terminated with signal SIGSEGV, Segmentation fault.
> #0 0x0000008b06198990 in svn_error_clear (err=0x300000000) at subversion/libsvn_subr/error.c:492
> 492 while (err->child)
> (gdb) bt
> #0 0x0000008b06198990 in svn_error_clear (err=0x300000000) at subversion/libsvn_subr/error.c:492
> #1 0x0000008ae29164e4 in shelf_save_notifier (baton=0xfffffffffffcb1f0, notify=0x8ad236ef00, pool=0x8ac9069d00)
> at subversion/libsvn_client/shelf.c:1075

I found that nb->shelved_func() in this line is
svn_swig_py_client_status_func() on swig Python bindings, and it is
incorrectly implemented that it isn't return value (i.e. void type).
This should be svn_client_status_func_t, which returns svn_error_t *.

I'll fix it.

Cheers,

-- 
Yasuhito FUTATSUKI <futatuki_at_yf.bsdclub.org> / <futatuki_at_poem.co.jp>
Received on 2019-12-20 14:33:40 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.