[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: swig-py3 str/bytes difference in svn_config_*()

From: Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
Date: Sat, 14 Dec 2019 03:55:14 +0900

On 2019/12/13 20:44, Yasuhito FUTATSUKI wrote:
> On 2019/12/13 19:47, Daniel Shahaf wrote:
>> Yasuhito FUTATSUKI wrote on Fri, Dec 13, 2019 at 17:28:18 +0900:
>>> Thank you for testing. I also tested and same result on FreeBSD
>>> with Python 3.6. It seems "z*" format in PyArg_ParseTuple() doesn't
>>> work I expected.
>>>
>>> On the other hand, I can't find good reason to care typemap for
>>> "const char *config_dir" input different from other MAY_BE_NULL types
>>> on Python bindings only, so I removed this special handling.
>>> Then, it works :)
>>
>> I don't see any reason either, and I confirm this version of the patch fixes
>> both issues. Thanks again for the quick fix.
>
> It seems this extra typemap have been forgotten to remove when
> MAY_BE_NULL was introduced.
>
> I'll commit this patch after testing on Python 2.7.

Done in r1871347 and r1871349.

Cheers,

-- 
Yasuhito FUTATSUKI <futatuki_at_yf.bsdclub.org> / <futatuki_at_poem.co.jp>
Received on 2019-12-13 19:56:41 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.