Re: swig-py3 str/bytes difference in svn_config_*()

On 2019/12/13 14:13, Yasuhito FUTATSUKI wrote:
> "const char *fname" is also used in svn_io_file_open() and svn_io_stat(),
> however both are marked as "%ignore" in subversion/bindings/swig/core.i,
> so it seems it can be added to the MAY_BE_NULL lists.
>
> [[[
> Index: subversion/bindings/swig/core.i
> ===================================================================
> --- subversion/bindings/swig/core.i     (revision 1871280)
> +++ subversion/bindings/swig/core.i     (working copy)
> @@ -370,7 +370,8 @@
>      const char *conflict_separator,
>      /* svn_cmdline_create_auth_baton */
>      const char *username,
> -    const char *password
> +    const char *password,
> +    const char *fname
>  };
>
>  /* -----------------------------------------------------------------------
> ]]]
This is wrong place to insert it, and missed comment. This shoud be

[[[
Index: subversion/bindings/swig/core.i
===================================================================
--- subversion/bindings/swig/core.i (revision 1871319)
+++ subversion/bindings/swig/core.i (working copy)
@@ -362,7 +362,9 @@
      /* svn_config_get */
      const char *default_value,
      /* svn_config_read_auth_data */
- const char *config_dir,
+ const char *config_dir,
+ /* svn_config_get_user_config_path */
+ const char *fname,
      /* svn_diff_file_output_merge */
      const char *conflict_original,
      const char *conflict_modified,
]]]

Cheers,

-- 
Yasuhito FUTATSUKI <futatuki_at_yf.bsdclub.org> / <futatuki_at_poem.co.jp>