Re: [PATCH] Fix wrapping of 'svn help' output at 80 chars

Nathan Hartman wrote on Wed, 04 Dec 2019 05:43 +00:00:
> I haven't confirmed this yet but I think that fixes it because at some
> point between initialization and this test running, sys.argv[0] is
> being modified.

Confirmed.

> I found two instances of sys.argv[0] being assigned in
> subversion/tests/cmdline/svntest/main.py -- see _internal_run_tests()
> and execute_tests(). Not sure if that's where it's happening.

Sounds plausible. The comments next to those assignments support
this theory.

> I'm running the full test suite now...
>
> If all goes well then I think it should be committed.

We can certainly commit it if your test run passes.

I think it will be even better for *_tests.py to use __file__ rather
than rely on sys.argv[0] to be correct, especially if the sys.argv[0]
fixup happens only after getopt_tests.py's top-level code is run. (We
can commit the patch I posted first and make a change along these lines
afterwards.)

Cheers,

Daniel
Received on 2019-12-04 09:51:23 CET