[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Merging branches/swig-py3 to trunk

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 1 Dec 2019 23:32:42 +0000

Nathan Hartman wrote on Sun, Dec 01, 2019 at 10:58:34 -0500:
> On Thu, Nov 28, 2019 at 4:05 PM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > I suggest to also grep for «sys.executable»; there are several
> > instances of that in trunk.
>
> I did such a search and sys.executable is found in:
>
> ./build/run_tests.py
> ./build/generator/gen_win.py
> ./build/generator/gen_vcnet_vcproj.py
> ./build/generator/gen_make.py
> ./subversion/tests/cmdline/svntest/main.py
> ./subversion/tests/cmdline/svnadmin_tests.py
> ./subversion/bindings/ctypes-python/setup.py
>
> I did not find files with extension other than .py containing
> sys.executable in latest trunk.
>
> I think nothing has changed about sys.executable in Python 3, so this
> should not affect anything.

Yes and no. sys.executable itself may not have changed, but code like
«subprocess.check_call([sys.executable, '-c', 'print "Hello world"'])»
would nevertheless be broken.

> > Y'all might consider starting a wiki page or a jira issue tracking
> > the categorization. I think it might be helpful to tracking the
> > work done/punted/pending.
>
> Agreed. I just wanted to get an initial list that is more-or-less
> accurate first. I think we're at that starting point now.
>
> Now, I wonder, how should we handle updates to the list as work
> progresses? With the wiki we can move items around in the list. With a
> Jira issue, would we add a comment with an updated list each time
> item(s) change status?

I suggest to just go ahead and create the wiki page.

> Meanwhile, here is a summary of the changes between my original list
> and the updated list by Yasuhito:

Cheers,

Daniel
Received on 2019-12-02 00:32:50 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.