Re: svn commit: r1869981 - /subversion/trunk/tools/dist/release.py

Daniel Shahaf wrote:
> Can't we just do this? —
>
> def recommended_release(version_being_rolled, versions_on_dist_release):
> stable_versions_on_dist_release = filter(lambda v: not v.is_prerelease(), versions_on_dist_release)
> if version_being_rolled.is_prerelease():
> return max(stable_versions_on_dist_release)
> else:
> return max(list(stable_versions_on_dist_release) + [version_being_rolled])
>
> I don't see what case it breaks in, out of all the ones you enumerate (1.8.0,
> 1.14.0-nightly, 1.14.0-rc1, 1.14.0 GA, 1.10.7, 1.8.0).

This is a case where explicit is better than implicit.

I am looking towards being able to generate all the release materials
from explicit stable inputs, and not treat the distribution servers or
website as parts of our source of truth.

- Julian
Received on 2019-11-19 21:36:52 CET