Re: [Patch] Support building with SWIG 4 on Python 3.x

On 13.11.2019 14:22, Jun Omae wrote:
> Hi,
>
> I tried to support building SWIG 4 on Python 3.x, and post patch.
>
> Since SWIG 4, -classic and -modern options have been dropped. As the
> result,
> SWIG generates new-style classes which are using property() instead of
> __swig_[gs]etmethods__.
>
> In attached patch, SWIG would generate new-style classes without
> __swig_[gs]etmethods__ when SWIG 3.x is used (-modern option would be
> used),
> in the same as SWIG 4.x.
>
> Verified by check-swig-py with:
>
>  - Python 3.[5678] with SWIG 1.3.40, 2.0.12, 3.0.12 on Ubuntu 16.04 amd64
>  - Python 2.7      with SWIG 3.0.12 and 4.0.1       on Ubuntu 16.04 amd64

Can you please update your patch so that it applies to the current
trunk? The current version causes conflicts on all three files that it
modifies.

Thanks,

-- Brane
Received on 2019-11-13 14:52:14 CET