[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn status should not show unmodified files in changelists

From: Nathan Hartman <hartman.nathan_at_gmail.com>
Date: Fri, 8 Nov 2019 09:31:41 -0500

On Fri, Nov 8, 2019 at 8:00 AM Julian Foad <julianfoad_at_apache.org> wrote:

> Nathan Hartman wrote:
> > > Friday% svn st -q
> > > --- Changelist 'foo':
> > > M iota
> > > Friday% vi A/mu
> > > Friday% svn commit -mm --cl foo
> > > Sending iota
> > > Sending A/mu
> > > # ... "Revert accidental commit"
> >
> > You're right. That would be immensely irritating...
>
> The opposite reading of that example is,
> # "Oh! I'm glad I used a changelist. I had forgotten both files were
> in my changelist and I would have accidentally omitted one from the
> commit if I had specified a filename instead of a changelist."
>
> But that example shows a trivial use of changelists -- just one or two
> files, one commit.
>
> In my example, I have about 60 files in one changelist and 20 in each of
> three more changelists, and it makes sense to keep these changelist
> assignments over a series of commits over many weeks. In each commit I
> only touch one or a few files.
>
> That changes things. I frequently want to check what files I have
> changed. I don't need or want to keep seeing my changes interspersed in
> a screenful of blank output. I don't need constant reminding of the
> changelist assignments of all my hundred-and-twenty files when I'm just
> looking to see what's ready for commit.

That is a good point. I hadn't properly considered the case of
changelists with more than a handful of items in them. But you're
right, nothing stops someone from carefully constructing changelists
with many hundreds of items in them. Which means that it would be
"immensely irritating" (to borrow my own earlier words) if you forget
to type the '--keep-changelists' argument to 'svn commit'.

So, if we revamp/reinvent/reboot the changelist feature, perhaps with
the addition of Daniel's suggestion to save changelists via a
svn:changelists property, perhaps also the ability to associate one
file to multiple changelists, then I'd lean toward my earlier
statement that 'svn status' without other options should print
modified items only, even if they're in a changelist; and that
printing the list of changelists and their contents (modified or not)
should be a 'svn changelists' or 'svn changelist-list' or 'svn
changelist --list' or some such command.

Nathan
Received on 2019-11-08 15:32:02 CET

This is an archived mail posted to the Subversion Dev mailing list.