[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue tracker housecleaning: SVN-1804

From: Nathan Hartman <hartman.nathan_at_gmail.com>
Date: Tue, 5 Nov 2019 11:34:28 -0500

On Tue, Nov 5, 2019 at 1:19 AM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:

> Nathan Hartman wrote on Mon, 04 Nov 2019 20:56 +00:00:
> > So before I rush to change the 'raise .. from' lines, I'll wait until
> > we decide which way to go with the required Python version.
>
> That's certainly one option, though personally, I'd suggest to first
> comment out the Ā«from detailĀ» part of the line, to ensure the script
> works correctly on at least one Python version, before looking into
> adding Python 3 support (either in parallel to, or instead of, Python 2
> support). This way, the script will remain releasable while the discussion
> about supported Python version happens.
>

Done in r1869419.

Also:

On Sat, Nov 2, 2019 at 4:00 AM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
wrote:

> > finally:
> > server.quit()
>
> As I mentioned before (but I couldn't tell what I want, sorry),
> smtplib.SMTP.quit() can raise exception. If server.quit() in finally
> block has raised an exception and it isn't caught, it will overwrite
> the exception raised in try block or re-raised in exception block.
>
> The exception on server.quit() itself doesn't affect the result that
> we could send message or not, and there is nothing we can do more
> about this SMTP session. So we can catch it, then safely ignore it or
> at most log its cause as warning, and continue the transaction.
> Even if the cause of exception is fatal, It doesn't directly affect next
> attempt to send message.
>

Forgot to mention it before but that's done in r1869378.

On Mon, Nov 4, 2019 at 1:29 AM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
wrote:

> In any case, To get mailer.py to work with Python 3, more fix is needed.
> Our svn.* modules map `char *' to `bytes' object, but current mailer.py
> doesn't
> care bytes vs str problems.
>

It's on my to-do list.

Thanks,
Nathan
Received on 2019-11-05 17:34:53 CET

This is an archived mail posted to the Subversion Dev mailing list.