[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Patch] swig-py3: .swig_<lang>_checked files are left after reconfiguration and distclean task

From: Jun Omae <jun66j5_at_gmail.com>
Date: Wed, 30 Oct 2019 20:41:41 +0900

Hi,

.swig_<lang>_checked targets are added in swig-py3_at_1850519 and the targets
.swig_<lang>_checked files will be created by the targets. However the files
are not removed and left after reconfiguration and distclean task.

I think we should remove those files on reconfiguration and distclean task.

---- START OF PATCH ----
commit e9662e8e284f778de13559a61ee3c081c96652d9
Author: Jun Omae <jun66j5_at_gmail.com>
Date: Wed Oct 30 15:56:09 2019 +0900

     On branch swig-py3: Remove .swig_{pl,py,rb}_checked files on reconfiguration
     and distclean task.

     * Makefile.in
       (clean-swig-pl, clean-swig-py, clean-swig-rb): Remove .swig_<lang>_checked
       file.

     * configure.ac
       Remove .swig_<lang>_checked files on reconfiguration.

diff --git Makefile.in Makefile.in
index 7f9529ab7..8753f98c3 100644
--- Makefile.in
+++ Makefile.in
@@ -912,6 +912,7 @@ EXTRACLEAN_SWIG_PL=rm -f $(SWIG_PL_SRC_DIR)/native/svn_*.c \
  # Makefile does not exist, DO NOT try to make it. But, if it doesn't exist,
  # then the directory is probably clean anyway.
  clean-swig-pl:
+ rm -f .swig_pl_checked
         if test -z "$(RELEASE_MODE)"; then \
           $(EXTRACLEAN_SWIG_PL); \
         fi
@@ -946,6 +947,7 @@ check-swig-py: swig-py
  EXTRACLEAN_SWIG_PY=rm -rf $(SWIG_PY_DIR)/svn_*.c $(SWIG_PY_DIR)/core.c \
                            $(SWIG_PY_DIR)/[a-z]*.py
  clean-swig-py:
+ rm -f .swig_py_checked
         rm -rf $(SWIG_PY_DIR)/libsvn
         if test -z "$(RELEASE_MODE)"; then \
           $(EXTRACLEAN_SWIG_PY); \
@@ -978,6 +980,7 @@ check-swig-rb: swig-rb svnserve
  EXTRACLEAN_SWIG_RB=rm -f $(SWIG_RB_SRC_DIR)/svn_*.c $(SWIG_RB_SRC_DIR)/core.c

  clean-swig-rb:
+ rm -f .swig_rb_checked
         rm -rf $(SWIG_RB_DIR)/test/repos $(SWIG_RB_DIR)/test/wc
         if test -z "$(RELEASE_MODE)"; then \
           $(EXTRACLEAN_SWIG_RB); \
diff --git configure.ac configure.ac
index ff36773c9..ce20b6fd0 100644
--- configure.ac
+++ configure.ac
@@ -1641,7 +1641,7 @@ fi
  AC_SUBST(SVN_CONFIG_SCRIPT_FILES)

  # Ensure that SWIG is checked after reconfiguration.
-rm -f .swig_checked
+rm -f .swig_checked .swig_pl_checked .swig_py_checked .swig_rb_checked

  dnl Provide ${host} for use in compiled code (for svn --version)
  AC_DEFINE_UNQUOTED([SVN_BUILD_HOST], "${host}",
---- END OF PATCH ----

-- 
Jun Omae <jun66j5_at_gmail.com> (大前 潤)
Received on 2019-10-30 12:51:05 CET

This is an archived mail posted to the Subversion Dev mailing list.