Re: Issue tracker housecleaning: SVN-1804

On Tue, Oct 29, 2019 at 11:36 AM Daniel Shahaf <d.s_at_daniel.shahaf.name>
wrote:

> Nathan Hartman wrote on Tue, Oct 29, 2019 at 11:11:58 -0400:
> > [[[
> > def finish(self):
> ⋮
> > except smtplib.SMTPRecipientsRefused as detail:
> > sys.stderr.write("mailer.py: SMTP recipient(s) refused: %s: %s\n"
> > % (self.to_addrs, detail,))
> > raise MessageSendFailure
>
> Would «raise MessageSendFailure from detail» make sense here, and in the
> next
> «except» case as well?
>

Yes. Good catch! I'll fix it.

> > I agree that the glob pattern in the log message is a bad idea as it
> reduces
>
> searchability. I've changed this to list each affected function
> explicitly.
>
> Thanks. HACKING does document this explicitly, too.

It sure does.

I think some of the earlier points you brought up are not yet mentioned in
HACKING. Making a note to look at that more carefully later and fix if
necessary...

Thanks,
Nathan
Received on 2019-10-29 17:40:46 CET