Re: Issue tracker housecleaning: SVN-1804

On Thu, Oct 24, 2019 at 6:20 PM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
wrote:

>
> Exception on SMTP.login will be repeated unless its response code indicates
> temporary error (3XX), because each try uses same parameters. On the other
> side, on SMTP.sendmail, with other sender, recipient, or even message data,
> try after failure may succeed, of course it depend on kind of exception.
> So I think those are not the same impact. Some of them are fatal and
> others are not. I guess that is why the reporter mensions only
> SMTPRecipientRefused in those exceptions.
>
> As how far we analyze and handle errors honestly is a trade-off
> between simplicity and precision, I don't want and don't aim to analyze
> too deep

Thank you to Daniel and Yasuhito for reviewing!

I think we should aim for simplicity, unless you feel strongly that we
should handle the login error separately.

Granted, this is not a perfect solution. Also it does not attempt to
identify and address any other unhandled exceptions that might occur
elsewhere in the program.

But it is an improvement, because right now we have no error handling
whatsoever for SMTP failures.

I'll fix the mistakes when I get back to the office and I'll post a
corrected secondary diff and proper log message...

Thanks again for reviewing.

Nathan
Received on 2019-10-25 05:03:11 CEST