On 2019/10/22 7:25, Yasuhito FUTATSUKI wrote:
> On 2019/10/21 19:55, Jun Omae wrote:
>> Hi,
>>
>> I'm trying to build and test swig-py3 branch (r1868677) on Ubuntu 16.04 with
>> Python 3.7, however I get FAILED(failures=16, errors=22) from the unit tests.
>>
>> Investigating the issue with helps of Yasuhito, that is caused by using old
>> SWIG version with no SWIG_PYTHON_STRICT_BYTE_CHAR feature. The
>> SWIG_PYTHON_STRICT_BYTE_CHAR feature is available since SWIG 3.0.9 but SWIG is
>> 3.0.8 in Ubuntu 16.04.
>>
>> I consider that we should warn the required SWIG version at least.
>>
>>
>> [1] https://github.com/swig/swig/blob/rel-3.0.10/CHANGES#L160
>
> Thank you for your report. I think if that feature or some other changes on
> swig-py3 breaks Python 2 (or accidentally Ruby and/or Perl bindings),
> we should bump required SWIG verersion or resolve issues with older SWIGs.
> However if it affect only with Python 3, we only need to restrict
> per Language bindings requirement.
>
> Anyway, I think we need more test with older SWIG (or restrict required
> SWIG version if we can't test).
With SWIG 3.0.0/2.0.12 + Python 2.7, make check-py passes all tests.
[[[
$ head -2 subversion/bindings/swig/python/core.py && make check-swig-py
# This file was automatically generated by SWIG (http://www.swig.org).
# Version 2.0.12
if [ "LD_LIBRARY_PATH" = "DYLD_LIBRARY_PATH" ]; then for d in /home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python/libsvn_swig_py /home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python/../../../libsvn_*; do if [ -n "$DYLD_LIBRARY_PATH" ]; then LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$d/.libs"; else LD_LIBRARY_PATH="$d/.libs"; fi; done; export LD_LIBRARY_PATH; fi; export PYTHONLIB=/home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python/.libs:/home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python; cd /home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python; /usr/local/bin/python2.7 /home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python/tests/run_all.py
..............s..........................................................................................................................................
----------------------------------------------------------------------
Ran 153 tests in 13.568s
OK (skipped=1)
]]]
[[[
$ head -2 subversion/bindings/swig/python/core.py && make check-swig-py
# This file was automatically generated by SWIG (http://www.swig.org).
# Version 3.0.0
if [ "LD_LIBRARY_PATH" = "DYLD_LIBRARY_PATH" ]; then for d in /home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python/libsvn_swig_py /home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python/../../../libsvn_*; do if [ -n "$DYLD_LIBRARY_PATH" ]; then LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$d/.libs"; else LD_LIBRARY_PATH="$d/.libs"; fi; done; export LD_LIBRARY_PATH; fi; export PYTHONLIB=/home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python/.libs:/home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python; cd /home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python; /usr/local/bin/python2.7 /home/futatuki/work/subversion/vwc/branches/swig-py3/subversion/bindings/swig/python/tests/run_all.py
..............s..........................................................................................................................................
----------------------------------------------------------------------
Ran 153 tests in 14.341s
OK (skipped=1)
]]]
Cheers,
--
Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
Received on 2019-10-22 01:35:59 CEST