[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Wed, 16 Oct 2019 14:12:50 +0200

On Wed, Oct 16, 2019 at 1:37 PM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp> wrote:
>
> On 2019/10/16 18:10, Johan Corveleyn wrote:
> > > Python 3 for the build and test process is only supported on *nix, not
> > on Windows.
> >
> > [[[
> > Traceback (most recent call last):
> > File "win-tests.py", line 134, in <module>
> > cp.items('options'))
> > File "build\generator\gen_win_dependencies.py", line 306, in __init__
> > self.find_libraries(False)
> > File "build\generator\gen_win_dependencies.py", line 327, in find_libraries
> > self._find_jdk(show_warnings)
> > File "build\generator\gen_win_dependencies.py", line 1085, in _find_jdk
> > vermatch = re.search(r'(([0-9]+(\.[0-9]+)+)(_[._0-9]+)?)', line, re.M)
> > File "C:\Python37\lib\re.py", line 183, in search
> > return _compile(pattern, flags).search(string)
> > TypeError: cannot use a string pattern on a bytes-like object
> > ]]]
> >
> > The fix is probably easy, but I'm just noting it here so we don't get
> > ahead of ourselves.
> >
>
> It seems the change addressing for it on swig-py3 branch is a part of
> r1822485, the hunks attached.

Ack.

This makes me wonder: should that be fixed specifically on trunk, and
nominated for backport to 1.13, so we can possibly claim basic support
for Python 3 in our build and test processes (in at least one released
version) before the end of this year?

Or should we reintegrate the swig-py3 branch ASAP, and nominate *that*
for backport to 1.13, so we can have Python 3 support, including swig
bindings?

-- 
Johan
Received on 2019-10-16 14:13:13 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.