Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

On 2019-10-15 07:04, Daniel Shahaf wrote:
> Yasuhito FUTATSUKI wrote on Sun, 13 Oct 2019 04:01 +00:00:
>> On 2019/10/13 7:24, Daniel Shahaf wrote:

>> I see. Now I agree it would suffice here.
>>
>>> So, how about:
>>>
>>> 1. Make the test use non-binary mode for changing and reading the
>>> file 'lambda'.
>>>
>>> 2. Locally revert the C part of r1841731 and make sure the modified test
>>> still (correctly) fails. (That revision both added the test and
>>> fixed the bug the test checks for.)
>>
>> So it looks sufficient to me.
>
> Cool. Will you perchance have time to do this? No worries if not.

Yes, I'll do it on FreeBSD on tonight or tomorrow night (in JST :)).
However I think it is also need to test for each 1 and 2 on Windows,
because r1841736 and r1841743 also were attempt to fix this test
on Windows, with Python 2.

> Also, what about the svnadmin_tests.py patch you posted upthread? Is
> there a reason not to go ahead and commit it to trunk? (and even nominate
> it for backport in 1.13.x/STATUS)

I think that is no probrem.

Cheers,

-- 
Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>