[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN-4065 - server should enforce LF normalization for svn:eol-style=native

From: Julian Foad <julianfoad_at_apache.org>
Date: Wed, 9 Oct 2019 14:10:15 +0100

Branko Čibej wrote:
>> The repos layer to a large extent transparent to properties and their
>> values, though not so much: it has some validation and even
>> "normalization" of "svn:" property names and values.  I feel this is
>> generally Bad; there is some room for repos-layer knowledge of
>> properties but we should have separated the concerns better.
> Does the repos layer actually normalize svn: properties? I know
> 'svnadmin load' can, but I don't believe the repos API does that?

AFAICT the RA parts of the libsvn_repos API never modify node props,
only revision props.

The normalization of node props done by 'svnadmin load' is implemented
in libsvn_repos through svn_repos_get_fs_build_parser6():


That is yet another case where it's implemented at the wrong level.
Here, "svnrdump load" can't share it. The dumpstream loader should be
refactored so svnadmin and svnrdump share code:
https://subversion.apache.org/issue/4780 "Factor out the dumpstream
loader editor driver".

- Julian
Received on 2019-10-09 15:10:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.