[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Python3 work [was: The run up to Subversion 1.13.0]

From: Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>
Date: Sat, 28 Sep 2019 03:10:16 +0900

Thank you for testing.

On 2019/09/24 5:48, Johan Corveleyn wrote:
> So, on to the next problem. When testing with Python 3.7.4 on Windows,
> I get the following error:
>
> [[[
> C:\research\svn\dev\swig-py3>python win-tests.py -c --log-level=DEBUG
> --release --swig=python R:\test_py
> 'ruby' is not recognized as an internal or external command,
> operable program or batch file.
> Testing Release configuration on local repository.
> -- Running Swig Python tests --
> Traceback (most recent call last):
> File "C:\research\svn\dev\swig-py3\subversion\bindings\swig\python\tests\run_all.py",
> line 23, in <module>
> import mergeinfo, core, client, delta, checksum, pool, fs, ra, wc,
> repository, \
> File "C:\research\svn\dev\swig-py3\subversion\bindings\swig\python\tests\trac\versioncontrol\tests\__init__.py",
> line 23, in <module>
> from trac.versioncontrol.tests import svn_fs
> File "C:\research\svn\dev\swig-py3\subversion\bindings\swig\python\tests\trac\versioncontrol\tests\svn_fs.py",
> line 73, in <module>
> REPOS_URL = pathname2url(temp_path).encode('UTF-8')
> File "C:\Python37\lib\nturl2path.py", line 53, in pathname2url
> if not ':' in p:
> TypeError: a bytes-like object is required, not 'str'
> [Test runner reported failure]
> ]]]

It seems that urllib.request.pathname2url() on Windows doesn't accept
bytes on Python 3, while on Linux/Unix it accepts both of bytes and str.

The patch attached may fix it.
  
> (The warning about 'ruby' is not a big deal I suppose, but it's also
> something I saw when running gen-make.py with python 3.7 -- not when
> I'm running it with python 2.7)
  
I think that message comes from build/generator/gen_win_dependencies.py,
GenDependenciesBase._find_ruby() line 967 (message from shell program
on Windows).

https://svn.apache.org/viewvc/subversion/branches/swig-py3/build/generator/gen_win_dependencies.py?revision=1862754&view=markup#l967

This may be also caused with Python 2, if 'ruby' is not in command
search path.

Cheers,

-- 
Yasuhito FUTATSUKI <futatuki_at_poem.co.jp>

  • text/plain attachment: stored
Received on 2019-09-27 20:14:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.