[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [GitHub] subversion pull request #5: pytest tests for svn-viewspec

From: Julian Foad <julianfoad_at_apache.org>
Date: Wed, 25 Sep 2019 14:25:14 +0100

> Github user pono closed the pull request at:
> https://github.com/apache/subversion/pull/5

For the record, this was closed by ASF infra at my request because I had
committed (a modified version of) the patch in r1827200:

r1827200 | julianfoad | 2018-03-19 13:43:41 +0000 (Mon, 19 Mar 2018) |
12 lines
Changed paths:
    M /subversion/trunk/tools/client-side/svn-viewspec.py
    A /subversion/trunk/tools/client-side/svnviewspec_test.py

Viewspec: Add regression tests for 'svn-viewspec.py'.

Patch by: Paul Hammant <paul[_AT_]hammant.org>
modified by me

* tools/client-side/svn-viewspec.py
   Prepare for testability: allow passing in a mock 'os.system' object, and
   make main() externally callable.

* tools/client-side/svnviewspec_test.py
   New file, for use with Python 'pytest'.


The stupid non-integration with GitHub shows GH users their standard
Pull Request UX to begin with, but supports virtually no follow-up after
that and is in fact an almost read-only mirror, so the PR flow is not
far off being a black hole. Apparently I had no way to comment there on
GH about what had happened to this PR, nor to mark it as closed myself.
All I could do was request ASF's infra department to close it as they
had the admin rights.

- Julian
Received on 2019-09-25 15:25:16 CEST

This is an archived mail posted to the Subversion Dev mailing list.