On Sat, Sep 21, 2019 at 10:28 AM Yasuhito FUTATSUKI <futatuki_at_poem.co.jp> wrote:
>
> On 2019/09/20 0:44, Daniel Shahaf wrote:
> > Yasuhito FUTATSUKI wrote on Thu, 19 Sep 2019 06:41 +00:00:
>
> >> The FAIL on test_merge_peg3 is a newline style issue on reading file
> >> in raw mode, which is introduced by my patch.
> >> (https://svn.apache.org/viewvc/subversion/branches/swig-py3/subversion/bindings/swig/python/tests/client.py?view=annotate#l438)
> >>
> >> Rest of those errors and failures are in the tests that were added only
> >> to swig-py, and it seems most of the causes of them are confusion of
> >> paths in platform specific format and Subversion's canoical format,
> >> as the comment in SubversionClientTestCase.test_update4() says.
> >>
> >> (I'll try to fix those issues on check-swig-py later, hopefully
> >> next weekend.)
> >
> > Thanks! No rush.
>
> Now I re-sync swig-py3 branch with trunk and make a patch addressing
> issues on testing on other than Unix/Linux platform.
>
> I've tested on FreeBSD 11.2, with Python 2.7 and Python 3.6.
>
> Could anyone please test it on Windows ?
Tested on Windows 7, and yes, this fixes the previous test failures
with Python 2.7.16. Thanks!
Test output:
[[[
Testing Release configuration on local repository.
-- Running Swig Python tests --
..............s.........................................................................................................
.................................
----------------------------------------------------------------------
Ran 153 tests in 63.214s
OK (skipped=1)
]]]
Building with Python 3.7.4 still fails with the same error though (no
problem, I know your patch wasn't addressing that, just mentioning it
here for completeness). Consequently I haven't been able to run the
swig-python tests with python 3.7 yet.
[[[
c:\python37\include\pytime.h(123): error C4115: 'timeval': named type
definition in parentheses
[C:\research\svn\dev\swig-py3\build\win32\vcnet-vcproj\libsvn_swig_py.vcxproj
]]]
--
Johan
Received on 2019-09-22 23:16:50 CEST