Re: Redirect cycle detected for URL, if redirect adds a trailing slash

Branko Čibej wrote:
>> It is a confusing error message, though. The redirect "cycle" is only
>> Subversion that made it a cycle, and is not the real problem. We could
>> do better.
>
> We could. Not canonicalizing the value of the Location header is an
> option; if it's not a valid URL, that's the server admin's problem, not
> ours (and as noted a number of times in other conversations, Subversion
> is not a browser so we don't have to worry about producing user-friendly
> URLs).

The attached patch, 'serf-no-canonicalize-redirect-1.patch', stops
canonicalizing the redirect, solving this problem.

I have only tested that it fixes the non-repository case I reported, and
verified that the existing test suite still passes. I haven't tested
what difference it makes to any currently untested forms of redirect
when accessing a repo.

WDYT?

ps. It's my favourite kind of patch: a code reduction/simplification.

- Julian