[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1865929 - /subversion/trunk/subversion/tests/cmdline/changelist_tests.py

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 26 Aug 2019 14:28:36 +0000

julianfoad_at_apache.org wrote on Mon, 26 Aug 2019 11:36 +00:00:
> Add a test for issue #4826, diff repos-wc non-infinite depth uses wrong depth.
>
> +++ subversion/trunk/subversion/tests/cmdline/changelist_tests.py Mon Aug 26 11:35:55 2019
> @@ -553,31 +580,20 @@ def diff_with_changelists(sbox):
> + ### XFAIL case
> + if is_repos_wc and (depth == 'empty' or depth == 'files' or
> depth == 'immediates') and subdir != '.':
> + print("XFAIL case: depth=%s, subdir='%s'\nexpect=%s\nactual=%s" % (depth, subdir,
> + str(expected_paths), str(paths)))
> + continue

Is this something temporary while you work on this, or meant to remain in the code longer-term?

(If the former, ignore the rest of this email.)

IIRC, tests aren't supposed to print() at all, certainly not from within
individual test functions. Instead, they should log at the following levels:

warning: test failure
error: bug in the test harness

So, if this print() is to remain in the code, I guess it should become a log.debug() call?

Cheers,

Daniel
Received on 2019-08-26 16:29:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.