[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1865523 - /subversion/trunk/subversion/libsvn_subr/sqlite3wrapper.c

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Wed, 21 Aug 2019 14:23:00 +0300

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

> Quoting https://sqlite.org/compile.html#_options_to_omit_features:
>
> Important Note: The SQLITE_OMIT_* options may not work with
> the amalgamation. SQLITE_OMIT_* compile-time options usually
> work correctly only when SQLite is built from canonical
> source files.
>
> and a bit later:
>
> Also, not all SQLITE_OMIT_* options are tested. Some
> SQLITE_OMIT_* options might cause SQLite to malfunction and/or
> provide incorrect answers.
>
> I think we should:
>
> - Revert r1865523

I see that this option has been supported from its introduction in 2010, and
that it appears to be covered in tests. Also, since it only affects the
journaling mode, apparently it does not participate in the parser/keyword
generation, which is listed as the reason of not using it with amalgamation:

  https://github.com/sqlite/sqlite/blob/cc3f3d1f055/src/parse.y
  https://github.com/sqlite/sqlite/blob/cc3f3d1f055/tool/mkkeywordhash.c
  https://github.com/sqlite/sqlite/blob/cc3f3d1f055/test/attach4.test#L82
  https://github.com/sqlite/sqlite/commit/bc6b8d73592ad72e674b10152012170a01c31c62

Thanks,
Evgeny Kotkov
Received on 2019-08-21 13:23:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.