[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1850651 - /subversion/trunk/subversion/mod_dav_svn/repos.c

From: Sergey Raevskiy <Sergey.Raevskiy_at_visualsvn.com>
Date: Thu, 15 Aug 2019 21:36:48 +0300

Hi!

I've attached a patch with fix. Log message:
[[[
* subversion/mod_dav_svn/repos.c
  (get_resource): Following up on r1850651: Set cleanup handler for
   FS warning logging regardless of presence of R->USER.

Patch by: sergey.raevskiy{_AT_}visualsvn.com
]]]

On Thu, Aug 15, 2019 at 8:25 PM Stefan Sperling <stsp_at_apache.org> wrote:
>
> On Thu, Aug 15, 2019 at 08:14:43PM +0300, Sergey Raevskiy wrote:
> > > /* if an authenticated username is present, attach it to the FS */
> > > if (r->user)
> > > @@ -2503,6 +2529,14 @@ get_resource(request_rec *r,
> > > apr_pool_cleanup_register(r->pool, cleanup_baton, cleanup_fs_access,
> > > apr_pool_cleanup_null);
> > >
> > > + /* We must degrade the logging context when the request is freed. */
> > > + cleanup_req_logging_baton =
> > > + apr_pcalloc(r->pool, sizeof(*cleanup_req_logging_baton));
> > > + cleanup_req_logging_baton->fs = repos->fs;
> > > + cleanup_req_logging_baton->connection = r->connection;
> > > + apr_pool_pre_cleanup_register(r->pool, cleanup_req_logging_baton,
> > > + cleanup_req_logging);
> >
> > Is it intended to set-up this cleanup handler only if R->USER is specified?
>
> Thanks Sergey!
>
> Good question. Looking back at this patch, this looks like an accident.
>
> Were you planning on writing a fix?

Received on 2019-08-15 20:37:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.