[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1864256 - /subversion/site/tools/upcoming.py

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 06 Aug 2019 14:41:04 +0000

Greg Stein wrote on Tue, 06 Aug 2019 07:58 +00:00:
> On Fri, Aug 2, 2019 at 12:53 PM <danielsh_at_apache.org> wrote:
> >...
> > +++ subversion/site/tools/upcoming.py Fri Aug 2 17:53:38 2019
> >...
> > +def get_reference_version():
> > + "Return the version to use as the oldest end of the 'svn log' output to generate."
> > + def _is_working_copy():
> > + return os.path.exists('subversion/include/svn_version.h')
> > + if _is_working_copy():
>
> Why a local func instead of just using os.path.exists() in the 'if'
> statement? If for doc purposes, then I think a comment would suffice.

Yes, for doc purposes. How would a comment be better than a one-line
helper function?

Cheers,

Daniel
Received on 2019-08-06 16:41:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.