[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

From: Yasuhito FUTATSUKI <futatuki_at_yf.bsdclub.org>
Date: Sat, 23 Feb 2019 14:04:44 +0900

On 2/20/19 11:05 PM, Troy Curtis Jr wrote:
> On Sun, Feb 17, 2019, 10:32 AM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>
>> Yasuhito FUTATSUKI wrote on Sun, 17 Feb 2019 06:13 +00:00:
>>> On 2/17/19 9:04 AM, Daniel Shahaf wrote:

>>> * If we want to install py2 bindings and py3 bindings at the same time,
>>> we must rename libsvn_swig_py library for py3.
>>
>> Good question, but I don't know the answer.
>>
>
> Do we think we want to address this directly, or rely on packagers to do
> whatever makes since for their environment? Perhaps we should just include
> an easy, optional, library name override option?

I think the former is better to save users who build from source from
unintentionally overwrite. It is also convenient to distinguish what
version of Python has been used if target Python major/minor version
number is added to libsvn_swig_py for py3 just like libpythonX.Ym is.

However, it doesn't intend to separate build tree immediately. To build
py3 bindings in addition to py2 bindings (or contrary), as we just do
currently, (1) clean swig-py stuff, (2) configure or gen-make.py again,
(3) and then rebuild swig-py.

Isn't it sufficient to include an easy, optional, library name override
option with different default value between py2 and py3?

Cheers,

-- 
Yasuhito FUTATSUKI
Received on 2019-02-23 06:08:45 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.