[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][swig-py3] Detach Python exception context in callbacks

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 06 Feb 2019 13:22:29 +0000

Yasuhito FUTATSUKI wrote on Tue, 05 Feb 2019 16:11 +0900:
> On 2/3/19 11:30 PM, Daniel Shahaf wrote:
> > Yasuhito FUTATSUKI wrote on Sun, 03 Feb 2019 20:52 +0900:
> >> The patch attached fix them by inserting PyErr_Fetch() and PyErr_Restore()
> >> save and restore Python error indicator.
> >>
> >> (The patch in other thread textually conflict with this patch, though)
> >
> > I don't have an opinion on this specific patch, but regarding the
> > textual conflict, I don't think it is an efficient workflow for you to
> > work with various patches flying around. Please feel free to commit
> > your patches directly to the branch for them to be reviewed post-commit,
> > or — if you prefer — to create one or more new branches off the swig-py3
> > branch and commit your patches thereto, for them to be merged back to
> > the swig-py3 branch once they have been reviewed.
> >
> > https://subversion.apache.org/docs/community-guide/general.html#lightweight-branches
> > (with s/trunk/swig-py3/g)
>
> Thank you for the guidance. Now I commited this patch as r1852967.
>
> Then I'll back to improve the former patch.

Great! Remember that you can always ask dev@ to review or advice on any
particular question, too, whether or not the related change has been committed.

Cheers,

Daniel
Received on 2019-02-06 14:22:50 CET

This is an archived mail posted to the Subversion Dev mailing list.