Re: [PATCH][swig-py3] Detach Python exception context in callbacks

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 03 Feb 2019 14:30:38 +0000

Yasuhito FUTATSUKI wrote on Sun, 03 Feb 2019 20:52 +0900:
> The patch attached fix them by inserting PyErr_Fetch() and PyErr_Restore()
> save and restore Python error indicator.
>
> (The patch in other thread textually conflict with this patch, though)

I don't have an opinion on this specific patch, but regarding the
textual conflict, I don't think it is an efficient workflow for you to
work with various patches flying around. Please feel free to commit
your patches directly to the branch for them to be reviewed post-commit,
or — if you prefer — to create one or more new branches off the swig-py3
branch and commit your patches thereto, for them to be merged back to
the swig-py3 branch once they have been reviewed.

https://subversion.apache.org/docs/community-guide/general.html#lightweight-branches
(with s/trunk/swig-py3/g)

Cheers,

Daniel
Received on 2019-02-03 15:30:51 CET

This message: [ Message body ]
Next message: Yasuhito FUTATSUKI: "Re: [PATCH][swig-py3] Detach Python exception context in callbacks"
Previous message: Yasuhito FUTATSUKI: "[PATCH][swig-py3] Detach Python exception context in callbacks"
In reply to: Yasuhito FUTATSUKI: "[PATCH][swig-py3] Detach Python exception context in callbacks"
Next in thread: Yasuhito FUTATSUKI: "Re: [PATCH][swig-py3] Detach Python exception context in callbacks"
Reply: Yasuhito FUTATSUKI: "Re: [PATCH][swig-py3] Detach Python exception context in callbacks"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]