[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] Incremental svn_delta_path_driver

From: Julian Foad <julianfoad_at_apache.org>
Date: Fri, 01 Feb 2019 12:53:58 +0000

Julian Foad wrote on 2019-01-16:
> Does the attached patch look reasonable? It provides an incremental
> version of the existing svn_delta_path_driver2() function, in which the
> caller can provide one path at a time instead of all at once at the
> start.

It's now committed and debugged:

* svn_delta_path_driver_start
* svn_delta_path_driver_step -- drives the editor to a new path
* svn_delta_path_driver_finish

And the all-at-once path driver is slightly upgraded: the new version svn_delta_path_driver3() passes the 'editor' and 'edit_baton' to the callback, which makes most implementations a bit simpler.

> We have a few (5 ~ 10) uses of svn_delta_path_driver2() in our codebase
> and I think a few more places already where an incremental path driver
> could be used if it existed, in addition to me now wanting to use it in
> "unshelve"

Only used in "unshelve", so far, and I might soon replace that with something else for Shelving v3, but I'm sure it will be useful anyway.

- Julian
Received on 2019-02-01 13:54:07 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.