[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [GitHub] subversion pull request #18: Add HTML lang="en"

From: Julian Foad <julianfoad_at_apache.org>
Date: Thu, 24 Jan 2019 10:55:20 +0000

Branko Čibej wrote:
> On Wed, 23 Jan 2019, 05:56 skotfred <git_at_git.apache.org wrote:
>>     https://github.com/apache/subversion/pull/18
>>
>>     Add HTML lang="en"
>>
>>     Primarily an accessibility concern for screen reader software.
>
> Before anyone starts saying that GitHub PR's are the wrong medium for sending patches:

We should discuss that in another thread. Bearing in mind that "we" (the ASF) set up that medium, what matters on this thread is that a user kindly offered us a patch.

> the changes themselves are mostly irrelevant, and those that add the "lang" attribute where it's not allowed by the DTD are actually wrong.

Could you respond to the user, on github, or would you prefer someone else to?

- Julian
Received on 2019-01-24 11:55:28 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.