Mark Phippard wrote on Fri, Jan 04, 2019 at 14:12:07 -0500:
> Would you consider this change to remove the border around the log? I
> think it looks more in line with the page as a whole:
>
> Index: generate-upcoming-changes-log.sh
> ===================================================================
> --- generate-upcoming-changes-log.sh (revision 1850430)
> +++ generate-upcoming-changes-log.sh (working copy)
> @@ -9,7 +9,7 @@
> ~/src/svn/site/tools/upcoming.py |
> {
> echo "<!-- Automatically generated by ^/subversion/site/tools/generate-upcoming-changes-log.sh -->"
> - echo "<pre>"
> + echo "<pre style="border: none">"
> ~/src/svn/site/tools/escape.py
> echo "</pre>"
> } > ~/src/svn/site/staging/upcoming.part.html
>
>
> I would have modified the site CSS but I assume we want this border in the
> other places on the site the <pre> tag is being used so this seems like the
> best way to turn it off.
+1, LGTM. Please change the double quotes to single quotes before you
commit. (The way you have it is not an sh syntax error, but it will
output an HTML syntax error.)
Cheers,
Daniel
Received on 2019-01-04 21:27:35 CET